-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TDL-20208 Add warning message for pro account plan. #49
Open
prijendev
wants to merge
6
commits into
TDL-20359-add-custom-exception-handling
Choose a base branch
from
TDL-20208-extremely-slow-data
base: TDL-20359-add-custom-exception-handling
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
TDL-20208 Add warning message for pro account plan. #49
prijendev
wants to merge
6
commits into
TDL-20359-add-custom-exception-handling
from
TDL-20208-extremely-slow-data
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prijendev
changed the title
Added warning message for pro account plan.
TDL-20208 Add warning message for pro account plan.
Aug 25, 2022
dbshah1212
reviewed
Aug 25, 2022
tap_freshdesk/client.py
Outdated
Comment on lines
154
to
156
LOGGER.warning("The `Surveys` and the `Timesheets` features are not supported in your current plan. "\ | ||
"So, Data collection cannot be initiated for satisfaction_ratings and time_entries streams. "\ | ||
"Please upgrade your account to `Pro` plan to use it.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is not the only reason so we should write this in might context like this might be the reason so check your account.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated warning
message.
savan-chovatiya
approved these changes
Aug 26, 2022
dbshah1212
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Manual QA steps
Risks
Rollback steps