Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra: reconfigure jest #402

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

infra: reconfigure jest #402

wants to merge 6 commits into from

Conversation

MilanKovacic
Copy link

No description provided.

@MilanKovacic MilanKovacic marked this pull request as ready for review April 8, 2024 18:17
joeldenning
joeldenning reviewed Apr 8, 2024
View reviewed changes
Copy link
Member

@joeldenning joeldenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why has husky been removed?

@MilanKovacic
Copy link
Author

Why has husky been removed?

Majority of CLI tools do not include husky configuration. This is mainly because most companies have their own existing infrastructure, and for beginners, it mostly confuses them.
For a proper husky configuration we would also need to include lint-staged, which is why I recommend we remove it for now, and re-add it later if there is interest.

@joeldenning
Copy link
Member

husky + pretty-quick is an alternative to lint-staged. I prefer pretty-quick because it doesn't require configuring all file extensions like lint-staged does (afaik)

This change removes husky without introducing lint-staged.

Perhaps we should change the scope of the PR to only include what is in the title - jest configuration - then a discussion and follow-up PR for husky or other changes?

ibacher
ibacher approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@ibacher ibacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the changeset, LGTM

.changeset/unlucky-suits-end.md
@@ -0,0 +1,5 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove this .changeset.

@MilanKovacic MilanKovacic marked this pull request as draft April 10, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeldenning joeldenning joeldenning left review comments

@ibacher ibacher ibacher approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MilanKovacic @joeldenning @ibacher