Skip to content

Commit

Permalink
Merge pull request #430 from singnet/grpc_certificate_issue_fix
Browse files Browse the repository at this point in the history
SNET-SDK/CLI | Adding root file as variable
  • Loading branch information
vinthedark authored Oct 6, 2021
2 parents d1bb95a + a38dc60 commit a66c3ac
Show file tree
Hide file tree
Showing 7 changed files with 5 additions and 4,345 deletions.
1 change: 0 additions & 1 deletion packages/sdk/MANIFEST.in

This file was deleted.

1 change: 0 additions & 1 deletion packages/sdk/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ def is_package_installed(package_name):
version=version_dict['__version__'],
packages=find_namespace_packages(include=['snet.*']),
namespace_packages=['snet'],
include_package_data=True,
url='https://github.com/singnet/snet-cli/tree/master/snet_sdk',
license='MIT',
author='SingularityNET Foundation',
Expand Down
4,337 changes: 0 additions & 4,337 deletions packages/sdk/snet/sdk/root.pem

This file was deleted.

1 change: 1 addition & 0 deletions packages/sdk/snet/sdk/root_certificate.py

Large diffs are not rendered by default.

6 changes: 2 additions & 4 deletions packages/sdk/snet/sdk/service_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from rfc3986 import urlparse
from snet.sdk.mpe.payment_channel_provider import PaymentChannelProvider
from snet.snet_cli.utils.utils import RESOURCES_PATH, add_to_path

from snet.sdk.root_certificate import root_certificate

class _ClientCallDetails(
collections.namedtuple(
Expand Down Expand Up @@ -69,9 +69,7 @@ def _get_grpc_channel(self):
if endpoint_object.scheme == "http":
return grpc.insecure_channel(channel_endpoint)
elif endpoint_object.scheme == "https":
with open('root.pem', 'rb') as f:
trusted_certs = f.read()
return grpc.secure_channel(channel_endpoint, grpc.ssl_channel_credentials(root_certificates=trusted_certs))
return grpc.secure_channel(channel_endpoint, grpc.ssl_channel_credentials(root_certificates=root_certificate))
else:
raise ValueError('Unsupported scheme in service metadata ("{}")'.format(endpoint_object.scheme))

Expand Down
2 changes: 1 addition & 1 deletion packages/sdk/snet/sdk/version.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "v2.0.8"
__version__ = "v2.0.9"
2 changes: 1 addition & 1 deletion packages/snet_cli/snet/snet_cli/version.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "v2.0.6"
__version__ = "v2.0.7"

0 comments on commit a66c3ac

Please sign in to comment.