Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update EIA-930 manual adjustments #328

Merged
merged 2 commits into from
Dec 29, 2023
Merged

feat: update EIA-930 manual adjustments #328

merged 2 commits into from
Dec 29, 2023

Conversation

rouille
Copy link
Collaborator

@rouille rouille commented Dec 29, 2023

Purpose

Update manual adjustments of timestamps in EIA-930 data. More specifically, the timestamps for the TEPC-ALL and IID-CISO interchange timeseries have been updated. No changes in the already adjusted generation timeseries and in the sign of the interchange.

What the code is doing

Shift timestamps to fix observed in time series. The identify_eia930_time_lags notebook has been used to identify the lags.

Testing

N/A

Where to look

Changes are in the eia930 module

Usage Example/Visuals

TEPC-ALL lag (7 hours):

TEPC-SRP
TEPC-WALC
Lag start 10/25/2021

IID-CISO lag (4 hours):

IID-CISO_2021
IID-CISO_2022
Lag occurs in 2021

Lag table:

# TEPC
|      |   all_years |   2021 |   2022 |   daylight savings |   standard time |
|:-----|------------:|-------:|-------:|-------------------:|----------------:|
| AZPS |           6 |      0 |      7 |                  1 |               7 |
| EPE  |           7 |      0 |      7 |                  1 |               7 |
| PNM  |           7 |      0 |      7 |                  7 |               7 |
| SRP  |           6 |      0 |      7 |                  4 |               7 |
| WALC |           7 |      0 |      7 |                  7 |               7 |

# IID
|      |   all_years |   2021 |   2022 |   daylight savings |   standard time |
|:-----|------------:|-------:|-------:|-------------------:|----------------:|
| AZPS |           0 |      0 |      0 |                  0 |               0 |
| CISO |           1 |      4 |      0 |                  1 |               0 |
| WALC |           0 |      0 |      0 |                  0 |               0 |

Review estimate

15min

Future work

N/A

Checklist

  • Update the documentation to reflect changes made in this PR
  • Format all updated python files using black
  • Clear outputs from all notebooks modified
    I will commit the notebooks after the review process and before merging.
  • Add docstrings and type hints to any new functions created

Sorry, something went wrong.

@rouille rouille added the data cleaning Cleaning and standardizing data label Dec 29, 2023
@rouille rouille requested a review from grgmiller December 29, 2023 00:16
@rouille rouille self-assigned this Dec 29, 2023
@rouille
Copy link
Collaborator Author

rouille commented Dec 29, 2023

@grgmiller, here are the plots after updating the eia930_raw.csv with changes in the manual_930_adjust function (see commit #762d5d9)

TEPC-SRP

TEPC-SRP
As you can see there is no shift before and after 10/25/2021

IID-CISO

IID-CISO_2021
IID-CISO_2022
No shift in 2021 and 2022

I have added the notebook to this PR. Outputs have been cleared.

Copy link
Collaborator

@grgmiller grgmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for your work on this.

@grgmiller grgmiller merged commit d2cf425 into development Dec 29, 2023
2 checks passed
@grgmiller grgmiller deleted the ben/eia930 branch December 29, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data cleaning Cleaning and standardizing data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants