Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subplant attributes table #405

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Conversation

grgmiller
Copy link
Collaborator

@grgmiller grgmiller commented Dec 20, 2024

Purpose

This PR adds a new subplant attributes table to results/plants data that contains subplant-specific attributes including:

  • subplant primary fuel
  • Fuel category
  • Nameplate capacity
  • Primary prime mover

This PR also moves the code introduced in d7b6368 from the helpers.assign_fleet_to_subplant_data function into the data_cleaning.aggregate_subplant_data_to_fleet function.

Advances CAR-4691

What the code is doing

Had to rearrange some functions to avoid circular imports

Testing

Running 2023 data pipeline

Review estimate

10 min

Future work

Maybe add more fields to this table

Checklist

  • Update the documentation to reflect changes made in this PR
  • Format all updated python files using black
  • Clear outputs from all notebooks modified
  • Add docstrings and type hints to any new functions created

@grgmiller grgmiller requested a review from rouille December 20, 2024 16:45
@grgmiller grgmiller mentioned this pull request Dec 20, 2024
4 tasks
Copy link
Collaborator

@rouille rouille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Add plant attributes to the plant_data file
@grgmiller grgmiller merged commit 38cf3b2 into ben/mapping Dec 20, 2024
1 check passed
@grgmiller grgmiller deleted the greg/subplant_attributes2 branch December 20, 2024 18:40
rouille pushed a commit that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants