Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final Cleanup #407

Merged
merged 4 commits into from
Dec 21, 2024
Merged

Final Cleanup #407

merged 4 commits into from
Dec 21, 2024

Conversation

grgmiller
Copy link
Collaborator

@grgmiller grgmiller commented Dec 20, 2024

Purpose

Final cleanup before the 2023 data release, including various small fixes:

  • bump the version to 0.6.0
  • Update the pipfile.lock to address security warnings
  • Add handling for geopy timeout errors: when using geopy to lookup missing lat/long or city/state/county, sometimes the request times out or the geocoder is unavailable. Previously this was causing the entire pipeline to crash. This adds a retry loop to retry the request once if unsuccessful, as well as handling both errors and returning nans if it fails twice.
  • Fixes a bug that introduced duplicate columns in the plant_data output file.
  • Fixes a bug where the downloads/eia923 directory was not being created if the year was < 2008 and the directory did not already exist
  • For years prior to 2019, outputs the plant_static_attributes table prior to the plant_data results instead of after so that it is available for debugging if the plant_data export fails
  • Updates the "H" frequency to "h" to address a deprecation warning.
  • Re-arranges the column order in the annual plant data file to include the plant attributes after the plant ID and before the quantitative data.

Advances CAR-4691

Testing

I'm going to do a full run of 2005-2023 to make sure everything is working, then merge

Review estimate

5 min

@grgmiller grgmiller marked this pull request as ready for review December 20, 2024 20:57
@grgmiller grgmiller requested a review from rouille December 20, 2024 20:57
Copy link
Collaborator

@rouille rouille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@grgmiller grgmiller merged commit a1925fb into development Dec 21, 2024
2 checks passed
@grgmiller grgmiller deleted the greg/cleanup branch December 21, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants