Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parts of computed source getting incorrect name #47

Merged
merged 4 commits into from
Oct 6, 2023

Conversation

christoph-blessing
Copy link
Member

  • Allow direct inserts into computed tables
  • Test if part of computed gets correctly named
  • Fix part of computed getting incorrect name
  • Refactor functional tests to use actors

@christoph-blessing christoph-blessing linked an issue Oct 6, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (84ac630) 98.71% compared to head (74df031) 98.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #47   +/-   ##
=======================================
  Coverage   98.71%   98.71%           
=======================================
  Files          23       23           
  Lines         780      780           
  Branches       95       95           
=======================================
  Hits          770      770           
  Misses          4        4           
  Partials        6        6           
Files Coverage Δ
link/infrastructure/factory.py 89.47% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@christoph-blessing christoph-blessing merged commit 758a26c into sinzlab:main Oct 6, 2023
8 checks passed
@christoph-blessing christoph-blessing deleted the fix_issue46 branch October 6, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Part tables of computed tables get created with incorrect name
1 participant