Skip to content

Commit

Permalink
Make tests more robust
Browse files Browse the repository at this point in the history 
We don't need the ignoreUnknownProperties for the tests as all the inputs
are static and well-known. Added test for the ignoreUnknonProperties flag
anyways.
  • Loading branch information
@janseeger
janseeger committed Nov 22, 2024
1 parent 31158ea commit 312581e
Show file tree
Hide file tree
Showing 9 changed files with 154 additions and 359 deletions.
128 changes: 16 additions & 112 deletions common/src/test/kotlin/de/sipgate/federmappe/common/decoder/BooleanTests.kt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,7 @@ class BooleanTests {
val data = mapOf<String, Any?>("a" to true)

// Act
val result =
serializer.deserialize(
StringMapToObjectDecoder(
data,
ignoreUnknownProperties = true,
),
)
val result = serializer.deserialize(StringMapToObjectDecoder(data))

// Assert
assertTrue(result.a)
Expand All @@ -45,13 +39,7 @@ class BooleanTests {
val data = mapOf<String, Any?>("a" to false)

// Act
val result =
serializer.deserialize(
StringMapToObjectDecoder(
data,
ignoreUnknownProperties = true,
),
)
val result = serializer.deserialize(StringMapToObjectDecoder(data))

// Assert
assertFalse(result.a)
Expand All @@ -68,13 +56,7 @@ class BooleanTests {
val data = mapOf<String, Any?>("a" to null)

// Act
val result =
serializer.deserialize(
StringMapToObjectDecoder(
data,
ignoreUnknownProperties = true,
),
)
val result = serializer.deserialize(StringMapToObjectDecoder(data))

// Assert
assertNull(result.a)
Expand All @@ -91,13 +73,7 @@ class BooleanTests {
val data = mapOf<String, Any?>("a" to true)

// Act
val result =
serializer.deserialize(
StringMapToObjectDecoder(
data,
ignoreUnknownProperties = true,
),
)
val result = serializer.deserialize(StringMapToObjectDecoder(data))

// Assert
assertEquals(true, result.a)
Expand All @@ -114,13 +90,7 @@ class BooleanTests {
val data = mapOf<String, Any?>("a" to false)

// Act
val result =
serializer.deserialize(
StringMapToObjectDecoder(
data,
ignoreUnknownProperties = true,
),
)
val result = serializer.deserialize(StringMapToObjectDecoder(data))

// Assert
assertEquals(false, result.a)
Expand All @@ -140,13 +110,7 @@ class BooleanTests {
)

// Act
val result =
serializer.deserialize(
StringMapToObjectDecoder(
data,
ignoreUnknownProperties = true,
),
)
val result = serializer.deserialize(StringMapToObjectDecoder(data))

// Assert
assertEquals(listOf(true, false, true), result.a)
Expand All @@ -166,13 +130,7 @@ class BooleanTests {
)

// Act
val result =
serializer.deserialize(
StringMapToObjectDecoder(
data,
ignoreUnknownProperties = true,
),
)
val result = serializer.deserialize(StringMapToObjectDecoder(data))

// Assert
assertEquals(listOf(true, false, true), result.a)
Expand All @@ -192,13 +150,7 @@ class BooleanTests {
)

// Act
val result =
serializer.deserialize(
StringMapToObjectDecoder(
data,
ignoreUnknownProperties = true,
),
)
val result = serializer.deserialize(StringMapToObjectDecoder(data))

// Assert
assertNull(result.a)
Expand All @@ -218,13 +170,7 @@ class BooleanTests {
)

// Act
val result =
serializer.deserialize(
StringMapToObjectDecoder(
data,
ignoreUnknownProperties = true,
),
)
val result = serializer.deserialize(StringMapToObjectDecoder(data))

// Assert
assertEquals(listOf(true, null, false), result.a)
Expand All @@ -244,13 +190,7 @@ class BooleanTests {
)

// Act
val result =
serializer.deserialize(
StringMapToObjectDecoder(
data,
ignoreUnknownProperties = true,
),
)
val result = serializer.deserialize(StringMapToObjectDecoder(data))

// Assert
assertEquals(listOf(true, null, false), result.a)
Expand All @@ -270,13 +210,7 @@ class BooleanTests {
)

// Act
val result =
serializer.deserialize(
StringMapToObjectDecoder(
data,
ignoreUnknownProperties = true,
),
)
val result = serializer.deserialize(StringMapToObjectDecoder(data))

// Assert
assertNull(result.a)
Expand All @@ -296,13 +230,7 @@ class BooleanTests {
)

// Act
val result =
serializer.deserialize(
StringMapToObjectDecoder(
data,
ignoreUnknownProperties = true,
),
)
val result = serializer.deserialize(StringMapToObjectDecoder(data))

// Assert
assertEquals(mapOf("a" to true, "b" to false, "c" to true), result.a)
Expand All @@ -322,13 +250,7 @@ class BooleanTests {
)

// Act
val result =
serializer.deserialize(
StringMapToObjectDecoder(
data,
ignoreUnknownProperties = true,
),
)
val result = serializer.deserialize(StringMapToObjectDecoder(data))

// Assert
assertEquals(mapOf("a" to true, "b" to null, "c" to false), result.a)
Expand All @@ -348,13 +270,7 @@ class BooleanTests {
)

// Act
val result =
serializer.deserialize(
StringMapToObjectDecoder(
data,
ignoreUnknownProperties = true,
),
)
val result = serializer.deserialize(StringMapToObjectDecoder(data))

// Assert
assertEquals(mapOf("a" to true, null to false, "c" to true), result.a)
Expand All @@ -374,13 +290,7 @@ class BooleanTests {
)

// Act
val result =
serializer.deserialize(
StringMapToObjectDecoder(
data,
ignoreUnknownProperties = true,
),
)
val result = serializer.deserialize(StringMapToObjectDecoder(data))

// Assert
assertEquals(mapOf("a" to true, "b" to false, "c" to true), result.a)
Expand All @@ -400,13 +310,7 @@ class BooleanTests {
)

// Act
val result =
serializer.deserialize(
StringMapToObjectDecoder(
data,
ignoreUnknownProperties = true,
),
)
val result = serializer.deserialize(StringMapToObjectDecoder(data))

// Assert
assertNull(result.a)
Expand Down
40 changes: 5 additions & 35 deletions common/src/test/kotlin/de/sipgate/federmappe/common/decoder/EnumTests.kt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,7 @@ class EnumTests {
val data = mapOf<String, Any?>("a" to "A")

// Act
val result =
serializer.deserialize(
StringMapToObjectDecoder(
data,
ignoreUnknownProperties = true,
),
)
val result = serializer.deserialize(StringMapToObjectDecoder(data))

// Assert
assertIs<TestClass>(result)
Expand All @@ -49,13 +43,7 @@ class EnumTests {
val data = mapOf<String, Any?>("a" to "A")

// Act
val result =
serializer.deserialize(
StringMapToObjectDecoder(
data,
ignoreUnknownProperties = true,
),
)
val result = serializer.deserialize(StringMapToObjectDecoder(data))

// Assert
assertIs<TestClass>(result)
Expand All @@ -72,13 +60,7 @@ class EnumTests {
val data = mapOf<String, Any?>("a" to null)

// Act
val result =
serializer.deserialize(
StringMapToObjectDecoder(
data,
ignoreUnknownProperties = true,
),
)
val result = serializer.deserialize(StringMapToObjectDecoder(data))

// Assert
assertIs<TestClass>(result)
Expand All @@ -98,13 +80,7 @@ class EnumTests {
val data = mapOf<String, Any?>("a" to mapOf("a" to "A"))

// Act
val result =
serializer.deserialize(
StringMapToObjectDecoder(
data,
ignoreUnknownProperties = true,
),
)
val result = serializer.deserialize(StringMapToObjectDecoder(data))

// Assert
assertIs<TestClass>(result)
Expand All @@ -121,13 +97,7 @@ class EnumTests {
val data = mapOf<String, Any?>("a" to mapOf("a" to "A"))

// Act
val result =
serializer.deserialize(
StringMapToObjectDecoder(
data,
ignoreUnknownProperties = true,
),
)
val result = serializer.deserialize(StringMapToObjectDecoder(data))

// Assert
assertIs<TestClass>(result)
Expand Down
Loading

0 comments on commit 312581e

Please sign in to comment.