Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix "get started" example #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ketronix-dev
Copy link

Same fixes, as in website PR

@CypherPotato
Copy link
Member

I think we can keep the using app syntax that you used in this code, because I really like it. Even though leaving the HttpRequest parameter explicit, as I mentioned in the previous PR, it won't be necessary.

Do you agree that it would be better if we left the parameter implicit?

@CypherPotato CypherPotato added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 10, 2024
@ketronix-dev
Copy link
Author

If we leave parameter explicit, JetBrains Rider shows error on this code, and we need to setup a type of delegate and request

@CypherPotato
Copy link
Member

As I mentioned in the other PR, the -rc, -beta versions are not final and are subject to change their final API before release. If you use the latest stable version (1.2 in this moment), I'm pretty sure Rider will compile with the implicit parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants