-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Modify makefile for macOS #182
base: master
Are you sure you want to change the base?
Conversation
brew install coreutils | ||
``` | ||
|
||
Al seguir la guia, antes de hacer los comandos make como se explican abajo deben hacer `cd src/` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
¿Qué aparece al ejecutar make
desde root?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahora lo pruebo de nuevo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pero hago el CD y anda, lo que probe recien clonando de 0 es que hay que meterle magia al makefile de cspec o bien a mano o bien subir el cambio xd
sudo make install
cd src && /Library/Developer/CommandLineTools/usr/bin/make all
make[1]: Nothing to be done for `all'.
cd tests/unit-tests && /Library/Developer/CommandLineTools/usr/bin/make all
make[1]: Nothing to be done for `all'.
cd tests/unit-tests && /Library/Developer/CommandLineTools/usr/bin/make test
LD_LIBRARY_PATH="../../src/build:../../cspec/release" ./build/commons-unit-test
dyld[41646]: Library not loaded: build/libcommons.so
Referenced from: <32B8E020-E64A-385C-B660-EB27289DD277> /Users/femedina/Fede/so-commons-library/tests/unit-tests/build/commons-unit-test
Reason: tried: 'build/libcommons.so' (no such file), '/System/Volumes/Preboot/Cryptexes/OSbuild/libcommons.so' (no such file), 'build/libcommons.so' (no such file), '/usr/local/lib/libcommons.so' (no such file), '/usr/lib/libcommons.so' (no such file, not in dyld cache), '/Users/femedina/Fede/so-commons-library/tests/unit-tests/build/libcommons.so' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/Users/femedina/Fede/so-commons-library/tests/unit-tests/build/libcommons.so' (no such file), '/Users/femedina/Fede/so-commons-library/tests/unit-tests/build/libcommons.so' (no such file), '/usr/local/lib/libcommons.so' (no such file), '/usr/lib/libcommons.so' (no such file, not in dyld cache)
make[1]: *** [test] Abort trap: 6
make: *** [test] Error 2
```Bash | ||
brew install gcc@14 | ||
brew install coreutils | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quizás también agregaría algún paso para hacer que gcc
apunte a gcc-14
usando un alias o reemplazando el link: https://stackoverflow.com/a/75648898/14089741
ln -s /opt/homebrew/bin/gcc-14 /usr/local/bin/gcc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no quiero cambiarle el gcc a alguien en su computadora de uso personal/laboral. La afectacion puede ser minima pero lo dejaria así
a menos que pueda hacerlo temporal o solo para una terminal en particular
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
¿En qué afectaría cambiar el gcc
? Si para el trabajo usan clang, podrían compilar con clang
. Veo muy poco probable que alguien quiera compilar explícitamente con clang
usando el alias gcc
que viene preinstalado.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lo que comentó no es tanto por el cambio en si mismo, sino porque el alumno va a tirar un comando que va a cambiar su config default sin siquiera entender que es gcc y clang.
No quiero que la catedra tenga nada que ver con un cambio de ese estilo, si podria agregar un alias o lo que sea, pero modificar uno default no me copa.
A nivel impacto supongo que salvo que sean unos megas hackers del re carajo no les cambia nada de nada
Yo creo que esto deberia mutar a devcontainer |
No pude hacer andar el make install directo desde root, tuve que hacerlo desde la carpeta source
Pensé que era por un problema con cspec pero lo pude instalar lo más bien
haciendo
Corre los test lo más bien, pero todo con el makefile del root no le gusta