Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/log extension #192

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feature/log extension #192

wants to merge 2 commits into from

Conversation

mesaglio
Copy link
Contributor

With this we can have less group logs in github
cc @RaniAgus @nahuemazzeo

@mesaglio mesaglio force-pushed the feature/log_extension branch from 667ead0 to 4b7ba90 Compare December 23, 2024 16:37
@@ -44,6 +44,11 @@ static bool _is_level_enabled(t_log* logger, t_log_level level);


t_log* log_create(char* file, char *program_name, bool is_active_console, t_log_level detail) {
if (!string_ends_with(file, ".log")) {
perror("Log file must have .log extension");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Podemos error_show()? Y también indentar con tabs así queda igual que el resto del código :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants