Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve issue after upgrade firebase_database to ^11.2.0 #20

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

Lzyct
Copy link
Contributor

@Lzyct Lzyct commented Dec 5, 2024

What it does

  • update the library version
    dependencies:
      flutter:
        sdk: flutter
      flutter_test:
        sdk: flutter
      firebase_database: ^11.2.0
      mockito: ^5.4.4
      firebase_core_platform_interface: ^5.3.1
    
    dev_dependencies:
      flutter_lints: ^5.0.0
  • fix the wrong import path for setupFirebaseCoreMocks method after upgrade firebase_database to ^11.2.0

How to test

  1. upgrade your firebase_database version
  2. run the test

Screenshot

image

@sitatec sitatec self-requested a review December 7, 2024 22:36
Copy link
Owner

@sitatec sitatec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏾

@sitatec sitatec merged commit a8c9fe3 into sitatec:main Dec 7, 2024
1 check passed
@lockieRichter
Copy link

Thanks for patching this folks, when will this be released on pub.dev?

@sitatec
Copy link
Owner

sitatec commented Dec 10, 2024

Done ✅️

@sitatec
Copy link
Owner

sitatec commented Dec 10, 2024

Thanks @Lzyct

@Lzyct
Copy link
Contributor Author

Lzyct commented Dec 11, 2024

Thanks @Lzyct

No credit on changelog? 🫣

@sitatec
Copy link
Owner

sitatec commented Dec 11, 2024

You are mentioned here: https://github.com/sitatec/firebase_database_mocks/releases/tag/v0.7.1
But I also mentioned you in the changelog just now. It will appear in pub.dev changelog page in the next release. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants