Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade stencil version and other minor and bugfix dependencies #126 #127

Merged
merged 3 commits into from
Nov 6, 2023

Conversation

colinscz
Copy link
Collaborator

@colinscz colinscz commented Oct 27, 2023

What kind of change does this PR introduce? (check at least one)

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the main branch for v2.x (or to a previous version branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@colinscz colinscz changed the title chore: upgrade stencil version and other minor and bugfix dependencies chore: upgrade stencil version and other minor and bugfix dependencies #126 Oct 27, 2023
@colinscz colinscz requested a review from ibirrer October 27, 2023 08:07
@colinscz colinscz marked this pull request as ready for review October 27, 2023 08:07
@colinscz colinscz self-assigned this Oct 27, 2023
Copy link
Collaborator

@ibirrer ibirrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. However I still get 1 critical vulnerability locally:

npm install
...
3 vulnerabilities (2 moderate, 1 critical)

@colinscz
Copy link
Collaborator Author

Looks good. However I still get 1 critical vulnerability locally:

npm install
...
3 vulnerabilities (2 moderate, 1 critical)

I guess this is the one from babel. For now we cannot do much about that. I think from time to time we have to live with some vulnerabilities coming up.

Probably when we upgrade the Angular version in the demo app we can mitigate that partially, from what I could find this is used there and in Jest. As long as Stencil doesn't go up with the Jest peer dependencies we are somewhat bound to that version.

@colinscz colinscz requested a review from ibirrer October 30, 2023 13:06
@ibirrer
Copy link
Collaborator

ibirrer commented Oct 30, 2023

Looks good. However I still get 1 critical vulnerability locally:

npm install
...
3 vulnerabilities (2 moderate, 1 critical)

I guess this is the one from babel. For now we cannot do much about that. I think from time to time we have to live with some vulnerabilities coming up.

Probably when we upgrade the Angular version in the demo app we can mitigate that partially, from what I could find this is used there and in Jest. As long as Stencil doesn't go up with the Jest peer dependencies we are somewhat bound to that version.

Fine for me, but we should re-open #76 then.

ibirrer
ibirrer previously approved these changes Oct 30, 2023
@colinscz colinscz force-pushed the chore/update-stencil-to-latest-minor-version branch from a77958e to 41e92b6 Compare November 1, 2023 09:27
ibirrer
ibirrer previously approved these changes Nov 6, 2023
@colinscz colinscz force-pushed the chore/update-stencil-to-latest-minor-version branch from 41e92b6 to 0d63c52 Compare November 6, 2023 09:37
@colinscz colinscz requested a review from ibirrer November 6, 2023 09:56
ibirrer
ibirrer previously approved these changes Nov 6, 2023
@colinscz colinscz merged commit 0f961ce into main Nov 6, 2023
@colinscz colinscz deleted the chore/update-stencil-to-latest-minor-version branch November 6, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants