-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade stencil version and other minor and bugfix dependencies #126 #127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. However I still get 1 critical vulnerability locally:
npm install
...
3 vulnerabilities (2 moderate, 1 critical)
I guess this is the one from babel. For now we cannot do much about that. I think from time to time we have to live with some vulnerabilities coming up. Probably when we upgrade the Angular version in the demo app we can mitigate that partially, from what I could find this is used there and in Jest. As long as Stencil doesn't go up with the Jest peer dependencies we are somewhat bound to that version. |
Fine for me, but we should re-open #76 then. |
a77958e
to
41e92b6
Compare
41e92b6
to
0d63c52
Compare
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
main
branch for v2.x (or to a previous version branch)fix #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: