Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow skipping logs #37

Closed
wants to merge 1 commit into from
Closed

Allow skipping logs #37

wants to merge 1 commit into from

Conversation

tiagotex
Copy link
Contributor

The logs are helpful while setting up the metrics but create too much noise during regular operation.

I've implemented skipping log production by using an option. Let me know if you have alternative solutions or prefer not to handle this in the gem.

The logs are helpful while setting up the metrics, but they create too much noise during normal operation.
@sj26
Copy link
Owner

sj26 commented May 14, 2023

Thanks for the contribution!

Is this the repeated "Publishing Sidekiq CloudWatch Metrics" lines? Totally agree they are way too noisy.

What if, instead of adding a new logging configuration option, we changed the noisier lines to logger.debug which should be excluded by default by sidekiq's logger configuration?

@ndbroadbent
Copy link
Contributor

I was looking for the same thing and found this PR. I think changing these to logger.debug would also be a good solution.

@sj26
Copy link
Owner

sj26 commented Jul 29, 2023

Thanks for this, but I've merged #39 which quietens logs by default. Please try it out.

@sj26 sj26 closed this Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants