Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove conditions that check if handlers are valid handlers for an event.
validate_handlers/2
first checks if__handled_events__
function is defined in each of the handlers and then checks if all handlers handle the event.However, at the time of checking if
__handled_events__
function is defined, the handler module may not be loaded. This will cause the functionvalidate_handlers/2
to return incorrect falsy result.Since the checks that
validate handlers
happen at run-time, this does not provide much more value compared to just letting it crash. That is whyvalidate_handlers/2
function is entirely removed from the code.