refactor: replace and remove loadBasicLesson #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are in the process of moving away from egghead-rails as the source of lesson metadata. This moves us along that path by eliminating one of th huge graphql queries for lesson metadata. issue: #1138
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jbranchaud
commented
Jul 15, 2022
Comment on lines
+54
to
+55
| updated_at | ||
| published_at |
There was a problem hiding this comment.
It looks like there are more changes here than there actually are. This primary adds:
updated_atpublished_atplaylist.lesson[].media_urlcourse.lesson[].media_url
And then the rest is logically rearranging/grouping the attributes.
joelhooks
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
guiding issue: #1138
The headline for me is that I think we can make a couple (4) small adjustments to the
loadLessonfunction for all our needs and then throw away theloadBasicLessonfunction. For starters, this will reduce confusion about which to use and when. There is no way to make that decision at a quick glance because both are loading most of the kitchen sink. From here, there is probably additional trimming down and clarifying that we can do.Here is the commit (7e4ce03) that originally introduced the
loadBasicLessonfunction. Since then a handful of attributes have been added to it. @joelhooks, let me know if I'm missing some important context for why this separate query was originally added.