Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add fzf-lua and nu_plugin_skim to the README #626

Merged
merged 5 commits into from
Nov 27, 2024

Conversation

LoricAndre
Copy link
Contributor

@LoricAndre LoricAndre commented Nov 27, 2024

Checklist

check the box if it is not applicable to your changes

  • I have updated the README with the necessary documentation
  • I have added unit tests
  • I have added end-to-end tests
  • I have linked all related issues or PRs
  • I have re-generated the completions and manpage using cargo xtask compgen and cargo xtask mangen

Description of the changes

closes #570
closes #418

@LoricAndre
Copy link
Contributor Author

@idanarye, @ibhagwan could you please take a look and see if you're all right with this ?

README.md Outdated Show resolved Hide resolved
@LoricAndre LoricAndre force-pushed the docs/add-friends branch 4 times, most recently from 72ee302 to 369d445 Compare November 27, 2024 16:51
@ibhagwan
Copy link

  -- optional for icon support
  dependencies = { "nvim-tree/nvim-web-devicons" },

I'm not sure if we need this part, although nice to have there's also mini.icons (part of the amazing mini.nvim) which is also used by default with LazyVim - perhaps it's better to direct users to the repo's README for more options instead?

@LoricAndre LoricAndre added this to the v0.14.0 milestone Nov 27, 2024
@LoricAndre
Copy link
Contributor Author

I'll merge this tomorrow if it's good with you two

@ibhagwan
Copy link

I'll merge this tomorrow if it's good with you two

Looks great, Ty @LoricAndre!

@LoricAndre LoricAndre merged commit f6eb98e into master Nov 27, 2024
1 check passed
@LoricAndre LoricAndre deleted the docs/add-friends branch November 27, 2024 20:44
@jasha-hrp
Copy link

jasha-hrp commented Dec 2, 2024

@LoricAndre it looks like these Readme updates got clobbered -- the README on master no longer has nushell plugin informatrion.

@LoricAndre LoricAndre restored the docs/add-friends branch December 2, 2024 17:12
@LoricAndre LoricAndre deleted the docs/add-friends branch December 2, 2024 18:45
@LoricAndre
Copy link
Contributor Author

Hmmm you're right, I need to check how that happened

@LoricAndre
Copy link
Contributor Author

OK sorry about this, it's a dumb mistake on my part, I'll revert it right away

@LoricAndre
Copy link
Contributor Author

@jasha-hrp thank you very much for noticing this, it should be fixed now !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants