This repository has been archived by the owner on Jan 31, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 20
fix: String representation of escrow address #238
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidterpay
added
backport/v1.x.x
Backport your PR to the v1.x.x release
backport/v2.x.x
Backport your PR to the v2.x.x release
labels
Nov 22, 2023
aljo242
reviewed
Nov 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test for this query?
aljo242
approved these changes
Nov 27, 2023
mergify bot
pushed a commit
that referenced
this pull request
Nov 27, 2023
* greedy approach to lane verification * docs * base lane testing * mev lane testing nits * abci top level testing done * network spamming in E2E * string rep of escrow address * nit * removing logs from testing * query test (cherry picked from commit 736b2d3)
mergify bot
pushed a commit
that referenced
this pull request
Nov 27, 2023
* greedy approach to lane verification * docs * base lane testing * mev lane testing nits * abci top level testing done * network spamming in E2E * string rep of escrow address * nit * removing logs from testing * query test (cherry picked from commit 736b2d3)
davidterpay
added a commit
that referenced
this pull request
Nov 28, 2023
* greedy approach to lane verification * docs * base lane testing * mev lane testing nits * abci top level testing done * network spamming in E2E * string rep of escrow address * nit * removing logs from testing * query test (cherry picked from commit 736b2d3) Co-authored-by: David Terpay <[email protected]>
davidterpay
added a commit
that referenced
this pull request
Nov 28, 2023
* greedy approach to lane verification * docs * base lane testing * mev lane testing nits * abci top level testing done * network spamming in E2E * string rep of escrow address * nit * removing logs from testing * query test (cherry picked from commit 736b2d3) Co-authored-by: David Terpay <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/v1.x.x
Backport your PR to the v1.x.x release
backport/v2.x.x
Backport your PR to the v2.x.x release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.