Skip to content
This repository has been archived by the owner on Jan 31, 2025. It is now read-only.

fix: String representation of escrow address #238

Merged
merged 12 commits into from
Nov 27, 2023

Conversation

davidterpay
Copy link
Contributor

No description provided.

@davidterpay davidterpay marked this pull request as ready for review November 22, 2023 18:29
@davidterpay davidterpay added backport/v1.x.x Backport your PR to the v1.x.x release backport/v2.x.x Backport your PR to the v2.x.x release labels Nov 22, 2023
Copy link
Contributor

@aljo242 aljo242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test for this query?

Base automatically changed from terpay/greedy-process-proposal to main November 27, 2023 21:43
@davidterpay davidterpay merged commit 736b2d3 into main Nov 27, 2023
8 checks passed
@davidterpay davidterpay deleted the terpay/escrow-address-string branch November 27, 2023 22:10
mergify bot pushed a commit that referenced this pull request Nov 27, 2023
* greedy approach to lane verification

* docs

* base lane testing

* mev lane testing nits

* abci top level testing done

* network spamming in E2E

* string rep of escrow address

* nit

* removing logs from testing

* query test

(cherry picked from commit 736b2d3)
mergify bot pushed a commit that referenced this pull request Nov 27, 2023
* greedy approach to lane verification

* docs

* base lane testing

* mev lane testing nits

* abci top level testing done

* network spamming in E2E

* string rep of escrow address

* nit

* removing logs from testing

* query test

(cherry picked from commit 736b2d3)
davidterpay added a commit that referenced this pull request Nov 28, 2023
* greedy approach to lane verification

* docs

* base lane testing

* mev lane testing nits

* abci top level testing done

* network spamming in E2E

* string rep of escrow address

* nit

* removing logs from testing

* query test

(cherry picked from commit 736b2d3)

Co-authored-by: David Terpay <[email protected]>
davidterpay added a commit that referenced this pull request Nov 28, 2023
* greedy approach to lane verification

* docs

* base lane testing

* mev lane testing nits

* abci top level testing done

* network spamming in E2E

* string rep of escrow address

* nit

* removing logs from testing

* query test

(cherry picked from commit 736b2d3)

Co-authored-by: David Terpay <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/v1.x.x Backport your PR to the v1.x.x release backport/v2.x.x Backport your PR to the v2.x.x release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants