This repository has been archived by the owner on Jan 31, 2025. It is now read-only.
feat: Lane's with custom tx adapters #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidterpay
added
backport/v1.x.x
davidterpay
commented
Nov 28, 2023
| @@ -14,8 +14,8 @@ func TxPriority(config Factory) base.TxPriority[string] { | |||
| return base.TxPriority[string]{ | |||
| GetTxPriority: func(goCtx context.Context, tx sdk.Tx) string { | |||
| bidInfo, err := config.GetAuctionBidInfo(tx) | |||
| if err != nil { | |||
| panic(err) | |||
| if err != nil || bidInfo == nil || bidInfo.Bid.IsNil() { | |||
There was a problem hiding this comment.
this is a better worst case in case a faulty tx gets inserted into the MEV lane, gets the lowest priority and will be purged anyways.
aljo242
approved these changes
Nov 28, 2023
Comment on lines
+112
to
+113
| WaitForHeight(s.T(), s.chain.(*cosmos.CosmosChain), height+3) | ||
| s.T().Logf("reached height %d", height+2) |
There was a problem hiding this comment.
difference between the heights here.
want to just add the logging to WaitForHeight()?
mergify bot
pushed a commit
that referenced
this pull request
Nov 28, 2023
* greedy approach to lane verification * docs * base lane testing * mev lane testing nits * abci top level testing done * network spamming in E2E * string rep of escrow address * nit * nit * nit v1.0.1 * removing logs from testing * query test * logging with tx info * nits * nit * nit * testing nit --------- Co-authored-by: Alex Johnson <[email protected]> (cherry picked from commit be4465a) # Conflicts: # block/proposals/proposals_test.go
mergify bot
pushed a commit
that referenced
this pull request
Nov 28, 2023
* greedy approach to lane verification * docs * base lane testing * mev lane testing nits * abci top level testing done * network spamming in E2E * string rep of escrow address * nit * nit * nit v1.0.1 * removing logs from testing * query test * logging with tx info * nits * nit * nit * testing nit --------- Co-authored-by: Alex Johnson <[email protected]> (cherry picked from commit be4465a)
davidterpay
added a commit
that referenced
this pull request
Dec 1, 2023
* greedy approach to lane verification * docs * base lane testing * mev lane testing nits * abci top level testing done * network spamming in E2E * string rep of escrow address * nit * nit * nit v1.0.1 * removing logs from testing * query test * logging with tx info * nits * nit * nit * testing nit --------- Co-authored-by: Alex Johnson <[email protected]> (cherry picked from commit be4465a) Co-authored-by: David Terpay <[email protected]>
davidterpay
added a commit
that referenced
this pull request
Dec 1, 2023
* feat: Lane's with custom tx adapters (#239) * greedy approach to lane verification * docs * base lane testing * mev lane testing nits * abci top level testing done * network spamming in E2E * string rep of escrow address * nit * nit * nit v1.0.1 * removing logs from testing * query test * logging with tx info * nits * nit * nit * testing nit --------- Co-authored-by: Alex Johnson <[email protected]> (cherry picked from commit be4465a) # Conflicts: # block/proposals/proposals_test.go * proposal test fix * decreasing e2e time since its timeouting --------- Co-authored-by: David Terpay <[email protected]> Co-authored-by: David Terpay <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I extend the signer adapter interface to be a part of each lane primarily because this will be tremendously helpful in logging proposals as they are built as this will allow us to intro-spec things like priority, signers, and more by lane.
Each lane already defines its own signer adapter, I just extend it a bit more by making the lane have to implement
GetTxInfowhich returns lane specific information about a transaction, including its priority.