This repository has been archived by the owner on Jan 31, 2025. It is now read-only.
feat: Adding READMEs throughout the codebase #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidterpay
added
backport/v1.x.x
davidterpay
requested review from
nivasan1,
aljo242 and
Eric-Warehime
as code owners
aljo242
reviewed
Nov 29, 2023
aljo242
approved these changes
Dec 1, 2023
block/proposals/README.md
Outdated
|
|
||
| After a given lane executes its `PrepareLaneHandler` or `ProcessLaneHandler`, it will return a set of transactions that need to be added to the current proposal that is being constructed. To update the proposal, `Update` is called with the lane that needs to add transactions to the proposal as well as the transactions that need to be added. | ||
|
|
||
| Proposals are updated iff: |
There was a problem hiding this comment.
Suggested change
| Proposals are updated iff: | |
| Proposals are updated _iff_: |
mergify bot
pushed a commit
that referenced
this pull request
Dec 1, 2023
* abci readme * done wit example for abci.go * SEA * base lane done * proposals * block readme * fixes * proposals fix (cherry picked from commit d2a7626)
mergify bot
pushed a commit
that referenced
this pull request
Dec 1, 2023
* abci readme * done wit example for abci.go * SEA * base lane done * proposals * block readme * fixes * proposals fix (cherry picked from commit d2a7626)
This was referenced Dec 1, 2023
davidterpay
added a commit
that referenced
this pull request
Dec 1, 2023
* abci readme * done wit example for abci.go * SEA * base lane done * proposals * block readme * fixes * proposals fix (cherry picked from commit d2a7626) Co-authored-by: David Terpay <[email protected]>
davidterpay
added a commit
that referenced
this pull request
Dec 1, 2023
* abci readme * done wit example for abci.go * SEA * base lane done * proposals * block readme * fixes * proposals fix (cherry picked from commit d2a7626) Co-authored-by: David Terpay <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.