This repository has been archived by the owner on Jan 31, 2025. It is now read-only.
fix: patch CheckTx handler for MEVCheckTxHandler #592
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes fix an issue with the
CheckTx
function in theMEVCheckTxHandler
struct. In the recovery handler for the function the error log was being assigned toerr
before being returned as an actual error value rather than a request response as expected.This was causing the
CListMempool
handler forCheckTx
in CometBFT to panic here, which when called fromReactor
via a gossiped transaction would cause the entire node to panic.This produced the following panic as an example: