fix(jasmine): returnValues() should be transformed to a chain of mock…

…ReturnValueOnce() (#628) * fix(jasmine): returnValues() should be transformed to a chain of mockReturnValueOnce() * chore: prettier * fix: returnValues callee could be variable or expression
skovhus · Dec 20, 2024 · 681a52c · 681a52c
1 parent 33a62f9
commit 681a52c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/src/transformers/jasmine-globals.test.ts b/src/transformers/jasmine-globals.test.ts
@@ -143,14 +143,15 @@ test('spyOn', () => {
     existingSpy.and.callThrough();
     spyOn(something, 'foo').and.stub().and.returnValue(42);
     mySpy.and.stub();
+    anotherSpy.and.returnValues('a', 'b');
     `,
     `
     jest.spyOn().mockReturnValue();
     jest.spyOn(stuff);
     jest.spyOn(stuff).mockImplementation(() => 'lol');
     existingSpy.mockImplementation(() => 'lol');
     jest.spyOn(stuff).mockReturnValue('lmao');
-    jest.spyOn(stuff).mockReturnValue(1).mockReturnValue(2).mockReturnValue(3);
+    jest.spyOn(stuff).mockReturnValueOnce(1).mockReturnValueOnce(2).mockReturnValueOnce(3);
     existingSpy.mockReturnValue('lmao');
     jest.spyOn();
     jest.spyOn(stuff).mockImplementation(() => {});
@@ -161,6 +162,7 @@ test('spyOn', () => {
     existingSpy.mockRestore();
     jest.spyOn(something, 'foo').mockReturnValue(42);
     mySpy.mockImplementation(() => {});
+    anotherSpy.mockReturnValueOnce('a').mockReturnValueOnce('b');
     `
   )
 })

diff --git a/src/transformers/jasmine-globals.ts b/src/transformers/jasmine-globals.ts
@@ -315,14 +315,14 @@ export default function jasmineGlobals(fileInfo, api, options) {
         }
 
         case 'returnValues': {
-          let mockReturnValuesCall = j.callExpression(
-            j.memberExpression(j.identifier('jest'), j.identifier('spyOn')),
-            path.node.callee.object.object.arguments ?? []
-          )
+          let mockReturnValuesCall = path.node.callee.object.object
 
           for (const argument of path.node.arguments) {
             mockReturnValuesCall = j.callExpression(
-              j.memberExpression(mockReturnValuesCall, j.identifier('mockReturnValue')),
+              j.memberExpression(
+                mockReturnValuesCall,
+                j.identifier('mockReturnValueOnce')
+              ),
               [argument]
             )
           }