Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ArrowKt to 2.0.0 #27

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

miguelalexteixeira
Copy link

@miguelalexteixeira miguelalexteixeira commented Dec 31, 2024

Description

  • Upgrade Kotlin to 2.1.0
    • Replaced deprecated kotlinOptions with compilerOptions
  • Upgrade ArrowKt to 2.0.0
    • Removed any code using Tuple10 and ValidatedNel, as they're no longer available
    • Replaced deprecated .sequence() with either and .bind()
    • Add unit tests for map operations

@miguelalexteixeira miguelalexteixeira changed the title Upgrade arrowkt 2.0.0 Upgrade ArrowKt to 2.0.0 Dec 31, 2024
@miguelalexteixeira
Copy link
Author

Sorry for the tag @sksamuel 😅
Could I get some feedback on these changes? I'd like to update Arrow in my project, but this lib is blocking it due do breaking changes in Arrow 2.0.0

@@ -80,20 +80,3 @@ fun <INPUT, OUTPUT, A, B, C, D, E, F, G, H, I, ERROR> Parser.Companion.compose(
zip(p1, p2, p3, p4, p5, p6, p7, p8, p9).map { (a, b, c, d, e, f, g, h, i) ->
f(a, b, c, d, e, f, g, h, i)
}

fun <INPUT, OUTPUT, A, B, C, D, E, F, G, H, I, J, ERROR> Parser.Companion.compose(
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how come this was removed ?

@sksamuel
Copy link
Owner

sksamuel commented Feb 5, 2025

looks good! one question added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants