-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependencies: Permit installation on Python 3.13 #6
base: master
Are you sure you want to change the base?
Conversation
Do you know why CI is not starting on this PR, @fkiraly? |
it is starting (and failing) - why do you believe it is not starting? |
The failure is likely since you changed to many things at once, e.g., upper bounds for various packages. I think the problem comes from I suggest we raise the bounds one-by-one, or it will be really hard to diagnose and fix. |
After pushing once more, CI started running again, so I guess it was just a hiccup on GHA, possibly just running out of runners in peak hours. |
I don't know how this would contribute to CI not starting at all?
I absolutely agree. This patch was not meant to address individual problems, just make the installation of PyCaret on Python 3.13 succeed, in order use the branch to quickly validate it on downstream CI jobs. I've adjusted the original post to reflect its purpose, and that it should not be merged. |
Probably some dependency conflicts. |
I think it was just a hiccup on GHA, at the time I was pushing to the branch. |
Please do not merge.
About
The patch satisfies the installation of PyCaret on Python 3.13 without needing a compiler. It does not validate relevant functionality.
Thoughts
The patch does not take care about actually resolving potential havocs on individual version updates yet. It is meant to use the branch to quickly validate it on downstream CI jobs, and to convey an overview about what needs to be addressed.
In this spirit, it certainly needs more love and validation, optimally on behalf of individual patches that address individual package updates.
NB: This patch builds upon @fkiraly's other one which relaxes the dependency on
pmdarima
. Thank you very much.pmdarima
dependency pycaret/pycaret#4129