Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: Permit installation on Python 3.13 #6

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

amotl
Copy link
Collaborator

@amotl amotl commented Feb 10, 2025

Please do not merge.

About

The patch satisfies the installation of PyCaret on Python 3.13 without needing a compiler. It does not validate relevant functionality.

uv pip install 'pycaret @ git+https://github.com/sktime/pycaret@python313'

Thoughts

The patch does not take care about actually resolving potential havocs on individual version updates yet. It is meant to use the branch to quickly validate it on downstream CI jobs, and to convey an overview about what needs to be addressed.

In this spirit, it certainly needs more love and validation, optimally on behalf of individual patches that address individual package updates.

NB: This patch builds upon @fkiraly's other one which relaxes the dependency on pmdarima. Thank you very much.

@amotl
Copy link
Collaborator Author

amotl commented Feb 13, 2025

Do you know why CI is not starting on this PR, @fkiraly?

@fkiraly
Copy link

fkiraly commented Feb 15, 2025

it is starting (and failing) - why do you believe it is not starting?

@fkiraly
Copy link

fkiraly commented Feb 15, 2025

The failure is likely since you changed to many things at once, e.g., upper bounds for various packages.

I think the problem comes from numpy 2.

I suggest we raise the bounds one-by-one, or it will be really hard to diagnose and fix.

@fkiraly fkiraly added the ci / build Continuous integration, unit testing & package distribution label Feb 15, 2025
@amotl
Copy link
Collaborator Author

amotl commented Feb 15, 2025

After pushing once more, CI started running again, so I guess it was just a hiccup on GHA, possibly just running out of runners in peak hours.

@amotl
Copy link
Collaborator Author

amotl commented Feb 15, 2025

The failure is likely since you changed to many things at once, e.g., upper bounds for various packages.

I don't know how this would contribute to CI not starting at all?

I think the problem comes from numpy 2.
I suggest we raise the bounds one-by-one, or it will be really hard to diagnose and fix.

I absolutely agree. This patch was not meant to address individual problems, just make the installation of PyCaret on Python 3.13 succeed, in order use the branch to quickly validate it on downstream CI jobs. I've adjusted the original post to reflect its purpose, and that it should not be merged.

@fkiraly
Copy link

fkiraly commented Feb 19, 2025

I don't know how this would contribute to CI not starting at all?

Probably some dependency conflicts.

@amotl
Copy link
Collaborator Author

amotl commented Feb 19, 2025

I think it was just a hiccup on GHA, at the time I was pushing to the branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci / build Continuous integration, unit testing & package distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants