Locationbugfix (#531)

* Random feature thoughts.

* Fixed a newly introduced bug that causes the diagnostics activity to crash with an NPE.

---------

Co-authored-by: JayDeeTay <[email protected]>

app/build.gradle

@@ -50,8 +50,8 @@ android {
         applicationId 'com.google.android.stardroid'
         minSdk 26
         targetSdk 34  // 35 breaks the UI
-        versionCode 1559
-        versionName "1.10.8"
+        versionCode 1560
+        versionName "1.10.9"
         buildConfigField 'String', 'GOOGLE_ANALYTICS_CODE', '""'
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
     }

app/src/main/java/com/google/android/stardroid/control/AbstractController.java

@@ -27,7 +27,10 @@
  */
 public abstract class AbstractController implements Controller {
   private static final String TAG = MiscUtil.getTag(AbstractController.class);
-  protected AstronomerModel model;
+
+  // This needs the inject annotation because *some* controllers are inject
+  // *sometimes* because the job of converting everything to dagger wasn't completed.
+  @Inject AstronomerModel model;
   protected boolean enabled = true;
 
   @Override

designdocs/ux.md

@@ -0,0 +1,17 @@
+# Overall UX
+## Random feature ideas
+* Do away with the initial splash screen (except maybe on first run?)
+* Start outside of the celestial sphere and fly forwards into it
+* Have different astronomical bodies at different radii - maybe this could be used to account for slight differences in parallax depending on place on Earth
+* Fly to other locations? Be on the moon looking back at Earth?
+* Touch an object for more information (obviously)
+* Configurable UI to account for accessibility preferences
+* Remove likely underused features like layers from the main UI
+* Can you find a more intuitive way to switch to manual mode?
+* Compass compensation
+* Camera mode
+* Notifications
+* Set/rise times
+* OTA updates
+* Real horizon
+*