Allowing ability to mount volumes in the provider deployment

sky-uk · Jan 10, 2025 · ddef6a9 · ddef6a9
1 parent 5fb45f4
commit ddef6a9
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 2 deletions.
diff --git a/config/manager/controller_manager_config.yaml b/config/manager/controller_manager_config.yaml
@@ -21,10 +21,12 @@ spec:
     replicas: 1
     podTemplateSpec:
       spec:
+        volumes: []
         securityContext:
           runAsNonRoot: true
         containers:
         - name: provider-service
+          volumeMounts: []
           securityContext:
             allowPrivilegeEscalation: false
           resources:

diff --git a/controllers/pipelines/provider_controller.go b/controllers/pipelines/provider_controller.go
@@ -53,7 +53,7 @@ func NewProviderReconciler(ec K8sExecutionContext, config config.KfpControllerCo
 func (r *ProviderReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
 	logger := log.FromContext(ctx)
 	startTime := time.Now()
-	logger.V(2).Info("reconciliation started")
+	logger.Info("reconciliation started", "request", req)
 
 	var provider = &pipelinesv1.Provider{}
 	if err := r.EC.Client.NonCached.Get(ctx, req.NamespacedName, provider); err != nil {
@@ -99,7 +99,7 @@ func (r *ProviderReconciler) Reconcile(ctx context.Context, req ctrl.Request) (c
 	}
 
 	duration := time.Since(startTime)
-	logger.V(2).Info("reconciliation ended", logkeys.Duration, duration)
+	logger.Info("reconciliation ended", logkeys.Duration, duration)
 
 	return ctrl.Result{}, nil
 }

diff --git a/helm/kfp-operator/templates/configmap.yaml b/helm/kfp-operator/templates/configmap.yaml
@@ -28,10 +28,12 @@ data:
         replicas: {{ .Values.provider.replicas }}
         podTemplateSpec:
           spec:
+            volumes: {{- if .Values.provider.volumes }}{{- toYaml .Values.provider.volumes | nindent 12 }}{{ else }} []{{ end }}
             securityContext:
               runAsNonRoot: true
             containers:
             - name: provider-service
+              volumeMounts: {{- if .Values.provider.volumeMounts }}{{- toYaml .Values.provider.volumeMounts | nindent 14 }}{{ else }} []{{ end }}
               securityContext:
                 allowPrivilegeEscalation: false
               resources:
@@ -43,3 +45,4 @@ data:
                     fieldPath: metadata.namespace
               - name: OPERATORWEBHOOK
                 value: {{ include "kfp-operator.fullname" . }}-controller-manager.{{ .Values.namespace.name }}:{{.Values.manager.runcompletionWebhook.servicePort}}/events
+              {{- if .Values.provider.env }}{{- $.Values.provider.env | toYaml | nindent 14 }}{{ end }}
diff --git a/local/values.yaml b/local/values.yaml
@@ -41,3 +41,16 @@ statusFeedback:
 providers:
   - kfp
   - vai
+
+provider:
+  env:
+    - name: GOOGLE_APPLICATION_CREDENTIALS
+      value: /etc/gcloud/key-file.json
+  volumes:
+    - name: gcp-credentials
+      secret:
+        secretName: gcp-credentials
+  volumeMounts:
+    - name: gcp-credentials
+      mountPath: /etc/gcloud
+      readOnly: true