Closes #332

Tasks

• Deploy complete provider Deployment from the controller
  • Deploy ConfigMap (introduced in Step 4) needed by Deployment, Should the controller deploy this or should we let users optionally deploy it separately as a way to configure a provider? This will be managed using Env vars within the deployment, to avoid the need to manage another configmap resource.
  • Use state transition logic like in other controllers (though we don't this in the runconfiguration controller, we just have a TODO to do it) Would require a rework of the state transition logic to not be tied to workflows, this should be done separately as it will be a large piece of work
• Remove provider helm chart (it should now be redundant)
• Test controller creates Deployment successfully
• Create constant for owner label key
• Handle updates to Provider resources
• Set SynchronizationState on Provider resource
  • Write decoupled tests for all state transitions
  • Current problematic scenario: failing deployment and then fixing it (add a test case for it)
• Write acceptance tests (see what we do for other reconcilers)
  • Ideally we wanna test all state transition cases, e.g. 1. create provider, 2. creates deployment, 3. deployment fails, 4. provider synchstate = failed
• Set Synchronized condition (we do this for all other resources)???
• What about ObservedGeneration? (It's on the CRD but we never set it explicitly)
• Set events on failure? Check if we do this for our other custom resources
• Make sure provider type isn't used anywhere and, if not, remove it from the CRD (and wherever else it's currently referenced)
• Move Provider permissions from manager-providers-viewer-rolebinding.yaml to roles.yaml
• Ensure all logging in the provider controller code is at the correct level
• Since this PR has changed the Provider CRD, do we need a v1alpha7 release?
  • Potentially not, because we haven't released v1alpha6 yet, so we can add it to it
• Update documentation

Useful Links

• Argo events eventsource controller code
• Deployment status docs