Merge pull request #219 from nohjunh/remove-defaultConfig-line

Remove redundant default config line and unused imports
skydoves · Oct 17, 2023 · 029a0c5 · 029a0c5
2 parents 5558a0b + daa980a
commit 029a0c5
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 5 deletions.
diff --git a/build-logic/convention/src/main/kotlin/AndroidApplicationConventionPlugin.kt b/build-logic/convention/src/main/kotlin/AndroidApplicationConventionPlugin.kt
@@ -14,7 +14,6 @@ class AndroidApplicationConventionPlugin : Plugin<Project> {
 
       extensions.configure<BaseAppModuleExtension> {
         configureKotlinAndroid(this)
-        defaultConfig.targetSdk = 32
       }
     }
   }

diff --git a/build-logic/convention/src/main/kotlin/AndroidLibraryConventionPlugin.kt b/build-logic/convention/src/main/kotlin/AndroidLibraryConventionPlugin.kt
@@ -2,10 +2,7 @@ import com.android.build.gradle.LibraryExtension
 import com.skydoves.chatgpt.configureKotlinAndroid
 import org.gradle.api.Plugin
 import org.gradle.api.Project
-import org.gradle.api.artifacts.VersionCatalogsExtension
 import org.gradle.kotlin.dsl.configure
-import org.gradle.kotlin.dsl.dependencies
-import org.gradle.kotlin.dsl.getByType
 
 class AndroidLibraryConventionPlugin : Plugin<Project> {
   override fun apply(target: Project) {
@@ -17,7 +14,6 @@ class AndroidLibraryConventionPlugin : Plugin<Project> {
 
       extensions.configure<LibraryExtension> {
         configureKotlinAndroid(this)
-        defaultConfig.targetSdk = 32
       }
     }
   }
-Original file line number
+Diff line change
@@ Expand Up / @@ -14,7 +14,6 @@ class AndroidApplicationConventionPlugin : Plugin<Project> { @@
           extensions.configure<BaseAppModuleExtension> {
             configureKotlinAndroid(this)
-            defaultConfig.targetSdk = 32
           }
         }
       }
@@ Expand Down @@