Refactor arrow key handling in toolbar and picker components for impr…

…oved readability
slab · Jan 10, 2025 · d3fb27d · d3fb27d
1 parent 06661f7
commit d3fb27d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 12 deletions.
diff --git a/packages/quill/src/modules/toolbar.ts b/packages/quill/src/modules/toolbar.ts
@@ -153,27 +153,24 @@ class Toolbar extends Module<ToolbarProps> {
     var target = e.currentTarget;
     if (!target) return;
 
-    switch (e.key) {
-      case 'ArrowLeft':
-      case 'ArrowRight':
+    if (e.key === 'ArrowLeft' || e.key === 'ArrowRight') {
         this.updateTabIndexes(target, e.key);
-        break;
-    }
+            }
   }
 
   updateTabIndexes(target: EventTarget, key: string) {
     const currentIndex = this.controls.findIndex(control => control[1] === target);
     const currentItem = this.controls[currentIndex][1];
     currentItem.tabIndex = -1;
 
-    let nextIndex;
+    let nextIndex: number | null = null;
     if (key === 'ArrowLeft') {
       nextIndex = currentIndex === 0 ? this.controls.length - 1 : currentIndex - 1;
     } else if (key === 'ArrowRight') {
       nextIndex = currentIndex === this.controls.length - 1 ? 0 : currentIndex + 1;
     }
 
-    if (nextIndex === undefined) return;
+    if (nextIndex === null) return;
     const nextItem = this.controls[nextIndex][1];
     if (nextItem.tagName === 'SELECT') {
       const qlPickerLabel = nextItem.previousElementSibling?.querySelectorAll('.ql-picker-label')[0];

diff --git a/packages/quill/src/ui/picker.ts b/packages/quill/src/ui/picker.ts
@@ -129,12 +129,9 @@ class Picker {
     var target = e.currentTarget;
     if (!target) return;
 
-    switch (e.key) {
-      case 'ArrowLeft':
-      case 'ArrowRight':
+    if (e.key === 'ArrowLeft' || e.key === 'ArrowRight') {
         this.updateTabIndexes(target, e.key);
-        break;
-    }
+            }
   }
 
   updateTabIndexes(target: EventTarget, key: string) {