make rate limit error code configurable #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vthacker
force-pushed
the
vthacker_rate_limit_error_code
branch
2 times, most recently
from
c945afd
to
089cf84
Compare
vthacker
changed the title
vthacker
force-pushed
the
vthacker_rate_limit_error_code
branch
from
089cf84
to
645d370
Compare
vthacker
commented
Feb 8, 2024
bryanlb
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We want to be able to configure how rate limit error HTTP code is sent back to clients.
Some clients might want to drop logs ( say to prioritize fresh logs ) and some might retry. So making the code configurable