Improve SlotReusedDetector #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexvanyo
force-pushed
the
av/improve-slot-reused-detector
branch
3 times, most recently
from
5919083
to
006b438
Compare
By resolving the call references to check against the parameter, this allows removing the custom shadowing logic, and also fixes cases where a different reference with the same name as the slot was causing false positives. Fixes slackhq#424 and fixes slackhq#434
alexvanyo
force-pushed
the
av/improve-slot-reused-detector
branch
from
006b438
to
fda504f
Compare
ZacSweers
approved these changes
Oct 21, 2024
compose-lint-checks/src/main/java/slack/lint/compose/SlotReusedDetector.kt
Outdated
Show resolved
Hide resolved
|
Excited to try to use this mechanism to fix #268 too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By resolving the call references to check against the parameter, this allows removing the custom shadowing logic, and also fixes cases where a different reference with the same name as the slot was causing false positives.
Fixes #424 and fixes #434