Add @Multipart/@Part Retrofit lint updates #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZacSweers
approved these changes
Oct 11, 2024
| @@ -55,18 +55,25 @@ class RetrofitUsageDetector : Detector(), SourceCodeScanner { | |||
| val annotationsByFqcn = node.uAnnotations.associateBy { it.qualifiedName } | |||
|
|
|||
| val isFormUrlEncoded = FQCN_FORM_ENCODED in annotationsByFqcn | |||
| val isMultipart = FQCN_MULTIPART in annotationsByFqcn | |||
There was a problem hiding this comment.
Nit before you merge: move this down to the line before the if statement that uses it
There was a problem hiding this comment.
resolved in 6161a32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the
RetrofitUsageDetectorto include support for@Multipartannotated methods and@Partannotated parameters per Retrofit doc. Added test cases for new lints and success path.Requirements (place an
xin each[ ])