-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for wire devices and yaml generation #183
Conversation
…de to manage PV fields.
Would it be possible to add a wire-collection to the I can make an issue if you would rather this be part of a different PR 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The yaml generation side of things looks good now and that pattern can be followed for other PVs that require fields. Happy to approve this.
Adding the wires to the Area
class means people can access magnets/wires/screens all in one place now too! Thanks
Thanks for reviewing @MattKing06 , and thanks for the PR @kabanaty ! I will merge! |
@kabanaty not sure why the merge to main for this PR broke the unit tests. Could you please take a look? From my end it looked like your branch was passing the checks. |
Updates for wire devices to address issues #168, #169, and #182.