Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for wire devices and yaml generation #183

Merged
merged 11 commits into from
Aug 13, 2024
Merged

Conversation

kabanaty
Copy link
Collaborator

@kabanaty kabanaty commented Aug 9, 2024

Updates for wire devices to address issues #168, #169, and #182.

  • wire.py now has methods to scan and abort wire scans
  • wire.py has plane-independent methods for setting ranges and plane selection
  • generate.py now accounts for PV fields (ex. MOTR.VELO) and generates yaml files properly

@MattKing06
Copy link
Collaborator

Would it be possible to add a wire-collection to the Area class in here

I can make an issue if you would rather this be part of a different PR 😄

Copy link
Collaborator

@MattKing06 MattKing06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The yaml generation side of things looks good now and that pattern can be followed for other PVs that require fields. Happy to approve this.

Adding the wires to the Area class means people can access magnets/wires/screens all in one place now too! Thanks

@nneveu
Copy link
Member

nneveu commented Aug 13, 2024

Thanks for reviewing @MattKing06 , and thanks for the PR @kabanaty ! I will merge!

@nneveu
Copy link
Member

nneveu commented Aug 13, 2024

closes #168 #169 #182

@nneveu nneveu merged commit 136ec3e into slaclab:main Aug 13, 2024
3 checks passed
@nneveu nneveu added bug Something isn't working enhancement New feature or request labels Aug 13, 2024
@nneveu
Copy link
Member

nneveu commented Aug 13, 2024

@kabanaty not sure why the merge to main for this PR broke the unit tests. Could you please take a look? From my end it looked like your branch was passing the checks.

@kabanaty kabanaty removed the bug Something isn't working label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants