Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Implement add folder button, options window (select and override colors.list default) #39

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ngAlexander9
Copy link
Contributor

@ngAlexander9 ngAlexander9 commented Jan 23, 2025

Added a new button to add folders to the list of files to convert.
It takes the folder and traverses through, selecting only files which can be converted. When generating the output file, it preserves the directory structure. For example, if the examples folder is added (examples/*.edl), the output files will be [output folder]/examples/*.ui.
image

Added the ability to set a flag to override the default colors.list, and provide the alternate path. #6
image
The options window provides rudimentary checking (does the file exist), but doesn't evaluate if the provided file is a valid colors.list content. Providing this file to the converter/parser is not yet implemented (will be in the convert method in main window)

Also added the select output folder in the General tab. Same behavior as the modal.

There could be improved styling in the options window....

Generalized the file-selection widget into its own component. It is a line edit and a button that opens a file dialog. Pretty handy interface element used in several locations.

Switched some print statements to use logging. These get formatted by pydm's logging configuration.

Also a tiny bugfix. Shouldn't set the mainwindow as the parent of optionswindow, otherwise the elements render in the same window. oof.

If you try to launch, it suffers from the circular import error (dataclasses.py interferes with dataclasses). Renaming the file resolves that issue. I figure I'd leave it to the others to change the filename.

@ngAlexander9 ngAlexander9 changed the title ENH: Implement add folder button ENH: Implement add folder button, options window (select and override colors.list default) Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant