Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core.server_scripts.Common): Set log level and format. #797

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Conversation

tristpinsm
Copy link
Collaborator

Description

Add a log handler with timestamps to capture the output of the rogue (and other) logs.

This works, but rogue is extremely verbose at the INFO level. It might be useful to set a more relaxed level for just the cryo-det modules.

Jira Issue

ESCRYODET-

Tests done on this branch

Function interfaces that changed

[Indicate here what is the interface that changed, preferably with a link to the code where the interface is defined]

What was the interface before the change

[Describe here how was the original interface]

What will be the new interface after the change

[Describe here how is the new interface, and what the difference with the original interface]

@github-actions github-actions bot added the core Changes to the core code, which is used in the server application label Sep 20, 2024
@tristpinsm tristpinsm marked this pull request as ready for review September 20, 2024 21:40
@github-actions github-actions bot added the client Changes to the client code label Sep 20, 2024
Copy link
Collaborator

@jlashner jlashner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Do you happen to know if warnings are what is already being printed, or if this will introduce new messages into the logs? I am fine with this as long as its not overwhelming, but it may confuse people who are used to looking through smurf-logs to debug.

@tristpinsm
Copy link
Collaborator Author

That's a good point. Warning is the default in python, and I haven't seen the level explicitly set in the rogue python code. Looking at the C++ logging it looks like it is set to error by default... So if your impression is that we have been running under that level so far I can change it.

@jlashner
Copy link
Collaborator

Do you have an example log-file at the warning level that I could look through? I could tell you if that's what we have by default or not.

@tristpinsm
Copy link
Collaborator Author

Sure, I can generate that later today

@tristpinsm
Copy link
Collaborator Author

I can't run with the full sodetlib software stack right now because of the firmware that is deployed on our test system, but just running SMuRF through setup to find_freq I don't see any warning messages.

@tristpinsm
Copy link
Collaborator Author

@swh76 with your stamp of approval I'll merge this and wrap it into the pysmurf release

@swh76 swh76 merged commit e29f26a into main Oct 28, 2024
17 checks passed
@swh76 swh76 deleted the tpm/logging branch October 28, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Changes to the client code core Changes to the core code, which is used in the server application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants