-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core.server_scripts.Common): Set log level and format. #797
Conversation
809da07
to
90d65f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Do you happen to know if warnings are what is already being printed, or if this will introduce new messages into the logs? I am fine with this as long as its not overwhelming, but it may confuse people who are used to looking through smurf-logs to debug.
That's a good point. Warning is the default in python, and I haven't seen the level explicitly set in the rogue python code. Looking at the C++ logging it looks like it is set to error by default... So if your impression is that we have been running under that level so far I can change it. |
Do you have an example log-file at the warning level that I could look through? I could tell you if that's what we have by default or not. |
Sure, I can generate that later today |
I can't run with the full |
@swh76 with your stamp of approval I'll merge this and wrap it into the |
Description
Add a log handler with timestamps to capture the output of the rogue (and other) logs.
This works, but rogue is extremely verbose at the
INFO
level. It might be useful to set a more relaxed level for just thecryo-det
modules.Jira Issue
ESCRYODET-
Tests done on this branch
Function interfaces that changed
[Indicate here what is the interface that changed, preferably with a link to the code where the interface is defined]
What was the interface before the change
[Describe here how was the original interface]
What will be the new interface after the change
[Describe here how is the new interface, and what the difference with the original interface]