Revert "Add a warning if a PopupWindow is in a layout"

This reverts commit 66652cd.

The warning in the gallery are hard to fix because the component inherit
from a layout and there is nowhere to place the popups

internal/compiler/layout.rs

@@ -580,14 +580,3 @@ pub fn create_new_prop(elem: &ElementRc, tentative_name: &str, ty: Type) -> Name
         }
     }
 }
-
-/// Return true if this type is a layout that has constraints
-pub fn is_layout(base_type: &ElementType) -> bool {
-    match base_type {
-        ElementType::Builtin(b) => {
-            matches!(b.name.as_str(), "GridLayout" | "HorizontalLayout" | "VerticalLayout" | "Row")
-        }
-        ElementType::Component(c) => is_layout(&c.root_element.borrow().base_type),
-        _ => false,
-    }
-}

internal/compiler/passes/flickable.rs

@@ -84,7 +84,7 @@ fn fixup_geometry(flickable_elem: &ElementRc) {
                 .borrow()
                 .children
                 .iter()
-                .filter(|x| crate::layout::is_layout(&x.borrow().base_type))
+                .filter(|x| is_layout(&x.borrow().base_type))
                 // FIXME: we should ideally add runtime code to merge layout info of all elements that are repeated (#407)
                 .filter(|x| x.borrow().repeated.is_none())
                 .map(|x| Expression::PropertyReference(NamedReference::new(x, prop)))
@@ -106,7 +106,7 @@ fn fixup_geometry(flickable_elem: &ElementRc) {
                 .borrow()
                 .children
                 .iter()
-                .filter(|x| crate::layout::is_layout(&x.borrow().base_type))
+                .filter(|x| is_layout(&x.borrow().base_type))
                 // FIXME: (#407)
                 .filter(|x| x.borrow().repeated.is_none())
                 .map(|x| Expression::PropertyReference(NamedReference::new(x, "min-width")))
@@ -122,7 +122,7 @@ fn fixup_geometry(flickable_elem: &ElementRc) {
                 .borrow()
                 .children
                 .iter()
-                .filter(|x| crate::layout::is_layout(&x.borrow().base_type))
+                .filter(|x| is_layout(&x.borrow().base_type))
                 // FIXME: (#407)
                 .filter(|x| x.borrow().repeated.is_none())
                 .map(|x| Expression::PropertyReference(NamedReference::new(x, "min-height")))
@@ -134,6 +134,15 @@ fn fixup_geometry(flickable_elem: &ElementRc) {
     });
 }
 
+/// Return true if this type is a layout that has constraints
+fn is_layout(base_type: &ElementType) -> bool {
+    if let ElementType::Builtin(be) = base_type {
+        matches!(be.name.as_str(), "GridLayout" | "HorizontalLayout" | "VerticalLayout")
+    } else {
+        false
+    }
+}
+
 /// Set the property binding on the given element to the given expression (computed lazily).
 /// The parameter to the lazily calculation is the element's children
 fn set_binding_if_not_explicit(

internal/compiler/passes/lower_popups.rs

@@ -51,15 +51,7 @@ fn lower_popup_window(
             parent_component.inherits_popup_window.set(true);
             return;
         }
-        Some(parent_element) => {
-            if crate::layout::is_layout(&parent_element.borrow().base_type) {
-                diag.push_warning(
-                    "PopupWindow shouldn't be a children of a layout".into(),
-                    &*popup_window_element.borrow(),
-                )
-            }
-            parent_element
-        }
+        Some(parent_element) => parent_element,
     };
 
     if Rc::ptr_eq(&parent_component.root_element, popup_window_element) {