Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rust API to grab the contents of a slint::Window into a slint::SharedImageBuffer #5445
Add Rust API to grab the contents of a slint::Window into a slint::SharedImageBuffer #5445
Changes from 1 commit
7d2c74d
672dc62
ee25b24
24ce7fc
115fcfe
668a025
d2d87b9
3faeaca
61e2509
42c59b7
47928c2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need force_next_frame_new_buffer given that you already set the buffer type in the next line? This will clear the caches.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, this isn't needed indeed. That said, I think I need to clear caches after this rendering, as the next call - from the windowing system or user - might pass an "age 1" buffer for example and caches don't apply to that one (As it's a different buffer).