Add a test that verifies that grab_window() returns something #5478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogoffart
approved these changes
Jun 25, 2024
internal/core/api.rs
Outdated
| @@ -1025,3 +1025,47 @@ impl std::error::Error for PlatformError { | |||
| fn error_is_send() { | |||
| let _: Box<dyn std::error::Error + Send + Sync + 'static> = PlatformError::NoPlatform.into(); | |||
| } | |||
|
|
|||
| // Sorry, can't test with rust test harness and multiple threads. | |||
There was a problem hiding this comment.
maybe this should be an "integration" test instead?
I was thinking perhaps there should be one test on each renderer
There was a problem hiding this comment.
Yeah, that would be better. So maybe a duplicated test in internal/renderers/*/tests/grab_window.rs ?
…ier callback During the invocation of the notifier, a mutable borrow is active. Don't try to acquire that again when entering the rendering code path for the screenshotting, by checking first if we have a surface to acquire the required graphics api enum (we don't) before trying to acquire the notifier.
tronical
force-pushed
the
simon/grab-window-test
branch
from
ea5c847
to
b643844
Compare
the Skia OpenGL or FemtoVG renderer
tronical
force-pushed
the
simon/grab-window-test
branch
from
b643844
to
e790f9b
Compare
|
I give up, random hangs in the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.