Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler crash when const propagating a property of `component-fa… #5480

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

ogoffart
Copy link
Member

…ctory` with its default value

We couldn't represent an empty component factory in the exrpession tree, so add Expression::EmptyComponentFactory for that

…ctory` with its default value

We couldn't represent an empty component factory in the exrpession tree,
so add Expression::EmptyComponentFactory for that
@ogoffart ogoffart requested a review from hunger June 25, 2024 16:51
Copy link
Member

@hunger hunger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to fix my issue. Thanks!

@ogoffart ogoffart merged commit bd18d8d into master Jun 25, 2024
36 checks passed
@ogoffart ogoffart deleted the olivier/component-factory branch June 25, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants