Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

live-preview: sidebar management #6125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

live-preview: sidebar management #6125

wants to merge 1 commit into from

Conversation

szecket
Copy link
Member

@szecket szecket commented Sep 13, 2024

quite a few things have happened here:

I changed the sidebars so they float over the content and don't move it.
I animated this transition.
There is now a drop shadow (which has draw issues) under the sidebars
the content scroll area adjusts to exist where there is still visible area and allows for scrolling of all the content

@hunger hunger changed the title sidebar management live-preview: sidebar management Sep 13, 2024
@hunger
Copy link
Member

hunger commented Sep 13, 2024

This will conflict hard with your previous PR... let me try to sort that out.

@hunger
Copy link
Member

hunger commented Sep 13, 2024

I took the liberty to polish your PR a bit and pushed it into another branch for review:

https://github.com/hunger/slint/commits/szecket-flaps/

It sits on top of your earlier polish branch now and has the conflicts resolved.

I extracted several stand-alone parts (polish to the status bar, etc.), I would suggest to merge all of those in separate PRs (I can do that if you want). Then we only have the floating status bars to consider...

For those I got rid of the SidebarApi and streamlined things a bit. I still have some problems with the left sidebar: showing/hiding it sometimes moves the scrollview to far to the left, so that half the visible preview-area is dead space:-/

Copy link
Member

@NigelBreslaw NigelBreslaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are in preview mode and quickly resize the live-preview window you can see the properties pane show up. Make it visible false also in preview mode?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants