Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempting a header change to optimize usability #6720

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Conversation

szecket
Copy link
Member

@szecket szecket commented Nov 4, 2024

the toggle that existed is the same as toggling a button - whcih can sit next to the closed library and properties.
properties should be editable while selection is active so those should be openable / visible whether in edit mode or not.
STILL TODO:

  • make dragging from library automatically into edit mode
  • add settings to either single select 'inspect' button or toggle on off
  • change display of active icon OR add icon for toggled mode for clearer display than blue icon for inspect

both library and properties can be shown anytime
and selection is is a toggle button at any time
suggestions:
goes hand in hand with the selection mode
likely requires settings for toggle or single
select.
TODO: make dragging from library automatically
into edit mode
Copy link
Member

@FloVanGH FloVanGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments, rest looks fine :-)

tools/lsp/ui/main.slint Outdated Show resolved Hide resolved
tools/lsp/ui/views/header-view.slint Outdated Show resolved Hide resolved
@szecket
Copy link
Member Author

szecket commented Nov 5, 2024

any thoughts on the change interaction wise?

@FloVanGH
Copy link
Member

FloVanGH commented Nov 5, 2024

any thoughts on the change interaction wise?

From my perspective it makes it better :-)

@ogoffart ogoffart merged commit c52fdd7 into master Nov 5, 2024
36 checks passed
@ogoffart ogoffart deleted the header-proposal branch November 5, 2024 17:51
@ogoffart
Copy link
Member

ogoffart commented Nov 5, 2024

Let's merge it then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants