Integration with GraphCompiler #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreyPavlenko
force-pushed
the
gc
branch
3 times, most recently
from
c26733d
to
6acdf0b
Compare
slyalin
reviewed
Jul 30, 2024
| }(); | ||
| return context; | ||
| } | ||
| #else |
There was a problem hiding this comment.
Could you activate the graph compiler path in run-time similarly how it is done for tpp-mlir? Via OV_MLIR_GRAPH_COMPILER environment variable that is activated by default when built with graph compiler. If both TPP-MLIR and graph compiled are available and activated via evn var in the same time, then error should be raised.
It will allow comparison of different modes in run-time without re-building.
There was a problem hiding this comment.
May I introduce a new env var - OV_MLIR_MODE that could be either TPP or GC? In this case we avoid the error.
There was a problem hiding this comment.
OK. When this variable is not set or empty, then upstream MLIR works only.
slyalin
reviewed
Jul 30, 2024
slyalin
reviewed
Jul 30, 2024
slyalin
reviewed
Jul 30, 2024
Grapth Compiler is disabled by default, to enable build with -DENABLE_GRAPH_COMPILER=ON
slyalin
reviewed
Jul 31, 2024
src/common/transformations/src/transformations/mlir/convert.cpp
Outdated
Show resolved
Hide resolved
slyalin
reviewed
Jul 31, 2024
src/common/transformations/src/transformations/mlir/convert.cpp
Outdated
Show resolved
Hide resolved
slyalin
approved these changes
Jul 31, 2024
Co-authored-by: Sergey Lyalin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Graph Compiler is disabled by default, to enable build with -DENABLE_GRAPH_COMPILER=ON