Fix graph partitioner when multiple MLIROp instances go side-by-side #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in return statement in is_dubug function.
|
For me, tests run and gracefully fail on |
Are you running without TPP (OV_MLIR_TPP=OFF env var)? With TPP it is expected to fail in Python. |
Spot on, I didn't. Works fine with that. |
adam-smnk
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed missing return statement in
is_dubugfunction.It should fix addmm pytorch layer tests (but the final graph form is not what we want to have -- due to ConvertLike ops that break the graph into multiple parts -- will be addressed later).