fix: node 10.x is end-of-life so default to 14.x (projen#1052)

Fixes projen#1034 Fixes projen#1050 BREAKING CHANGE: The default minimum Node.js version for node projects is now 14.x since Node 10.x is now end-of-life. Therefore we also change the default build container for JSII projects is now jsii/superchain:node14. Co-authored-by: Elad Ben-Israel <[email protected]>
smallcase · Sep 12, 2021 · 581ee96 · 581ee96
1 parent 402cf6b
commit 581ee96
Show file tree

Hide file tree

Showing 18 changed files with 63 additions and 63 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
diff --git a/.github/workflows/upgrade.yml b/.github/workflows/upgrade.yml
diff --git a/.projen/deps.json b/.projen/deps.json
diff --git a/.projen/tasks.json b/.projen/tasks.json
diff --git a/.projenrc.js b/.projenrc.js
@@ -41,7 +41,7 @@ const project = new JsiiProject({
 
   projenDevDependency: false, // because I am projen
   releaseToNpm: true,
-  minNodeVersion: '10.17.0',
+  minNodeVersion: '14.17.0',
   codeCov: true,
   defaultReleaseBranch: 'main',
   gitpod: true,

diff --git a/package.json b/package.json
diff --git a/src/__tests__/__snapshots__/integ.test.ts.snap b/src/__tests__/__snapshots__/integ.test.ts.snap
diff --git a/src/__tests__/__snapshots__/jsii.test.ts.snap b/src/__tests__/__snapshots__/jsii.test.ts.snap
diff --git a/src/__tests__/dev-env.test.ts b/src/__tests__/dev-env.test.ts
@@ -100,14 +100,14 @@ describe('dev environment docker options', () => {
     });
 
     // WHEN
-    project.gitpod?.addDockerImage(DevEnvironmentDockerImage.fromImage('jsii/superchain'));
+    project.gitpod?.addDockerImage(DevEnvironmentDockerImage.fromImage('jsii/superchain:node14'));
     project.devContainer?.addDockerImage(DevEnvironmentDockerImage.fromImage('jsii/uberchain'));
 
 
     // THEN
     const outdir = synthSnapshot(project);
     const gitpodSnapshot = outdir[GITPOD_FILE];
-    expect(gitpodSnapshot).toContain('image: jsii/superchain');
+    expect(gitpodSnapshot).toContain('image: jsii/superchain:node14');
 
     const devContainerSnapshot = outdir[DEVCONTAINER_FILE];
     expect(devContainerSnapshot).toStrictEqual({

diff --git a/src/__tests__/integration/cdk8s/cdk8s.common.js b/src/__tests__/integration/cdk8s/cdk8s.common.js
@@ -1,5 +1,5 @@
 exports.options = {
-  minNodeVersion: '10.17.0',
+  minNodeVersion: '14.17.0',
   repository: 'https://github.com/awslabs/cdk8s.git',
   authorName: 'Amazon Web Services',
   authorUrl: 'https://aws.amazon.com',