Add option for empty default values #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoand
added a commit
to geoand/quarkus
that referenced
this pull request
Jan 8, 2025
This is done in order to avoid the overhead of looking up properties that won't be used anyway Requires: smallrye/smallrye-context-propagation#477
geoand
added a commit
to geoand/quarkus
that referenced
this pull request
Jan 8, 2025
This is done in order to avoid the overhead of looking up properties that won't be used anyway Requires: smallrye/smallrye-context-propagation#477
|
@geoand apparently, we have a requirement for commits to be signed now (first time I hear about this, BTW):
|
|
Interesting, let me check and see how that works |
geoand
added a commit
to geoand/quarkus
that referenced
this pull request
Jan 8, 2025
This is done in order to avoid the overhead of looking up properties that won't be used anyway Requires: smallrye/smallrye-context-propagation#477 Signed-off-by: Georgios Andrianakis <[email protected]>
|
Should be okay hopefully :) |
|
Apparently not :-/ |
|
I'll try again |
|
Your commit does seem to be signed, so I'm not sure that's it. |
In Quarkus at static init time we build what is essentially a no-op CP instance, but creating this instance currently incurs some overhead due to the use of Config to look up default values. This change, will allow Quarkus to set empty default values option
geoand
force-pushed
the
empty-default-values
branch
from
24d2deb to
568440c
Compare
|
Tried again |
geoand
added a commit
to geoand/quarkus
that referenced
this pull request
Jan 8, 2025
This is done in order to avoid the overhead of looking up properties that won't be used anyway Requires: smallrye/smallrye-context-propagation#477 Signed-off-by: Georgios Andrianakis <[email protected]>
gsmet
pushed a commit
to geoand/quarkus
that referenced
this pull request
Jan 9, 2025
This is done in order to avoid the overhead of looking up properties that won't be used anyway Requires: smallrye/smallrye-context-propagation#477 Signed-off-by: Georgios Andrianakis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Quarkus at static init time we build what is
essentially a no-op CP instance, but creating
this instance currently incurs some overhead
due to the use of Config to look up default values.
This change, will allow Quarkus to set empty
default values option and slightly improve startup