Improve event loop integration #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ladicek
force-pushed
the
improve-eventloop-integration
branch
2 times, most recently
from
9055715 to
9118c62
Compare
|
This should fix quarkusio/quarkus#45061 |
This commit mainly improves the `Timeout` strategy implementation to fail the invocation on timeout on the original thread, if it was remembered previously (that is, in case of an event loop). As a side effect, this commit also makes the `TimeoutExecution` class a little smaller.
Ladicek
force-pushed
the
improve-eventloop-integration
branch
2 times, most recently
from
c6b0bfd to
eb83fe2
Compare
The `EventLoop` interface was simplified: the `isEventLoopThread()` method was removed and instead, the `executor()` method is supposed to return `null` if the current thread is not an event loop thread. Further, the `VertxEventLoop` implementation considers all Vert.x threads "event loops", even worker threads. Finally, the `VertxExecutor` and `ThreadOffload` classes make bigger effort to keep the execution on the original Vert.x context as remembered at the beginning by `RememberEventLoop`.
The improvements mainly consist of: - running each service call on a separate duplicated context; - running each test on an event loop thread and on a worker thread. This better simulates what happens in practice (at least in Quarkus). Further, some new tests are added: - timeouts with Vert.x; - asynchronous execution with Vert.x, where the future is completed on a different kind of thread than the original.
Ladicek
force-pushed
the
improve-eventloop-integration
branch
from
eb83fe2 to
8dadb5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.