Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smallrye.jwt.client.tls.certificate to support inlined TLS certificates #596

Merged
merged 1 commit into from
May 17, 2022

Conversation

sberyozkin
Copy link
Contributor

@sberyozkin sberyozkin commented May 16, 2022

Fixes #595.

@MikeEdgar Hi Mike, I'm keeping #593 open, in case we'd like to go ahead and support random URL schems via the custom resolvers.

I've updated one of the unit tests to check a new property since there is another test there which checks the certificate path

@sberyozkin sberyozkin requested a review from MikeEdgar May 16, 2022 11:58
@sberyozkin sberyozkin changed the title Add smallrye.jwt.tls.certificate to support inlined TLS certificates Add smallrye.jwt.client.tls.certificate to support inlined TLS certificates May 16, 2022
Copy link
Member

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thank you @sberyozkin

@sberyozkin sberyozkin merged commit 2c8931d into smallrye:main May 17, 2022
@sberyozkin sberyozkin deleted the tls_certificate_property branch May 17, 2022 10:20
@sberyozkin sberyozkin added this to the 3.5.0 milestone May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for inlined TLS certificates
2 participants