Improve conversion of Mutiny handlers #1037
Open
+151
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jponge @cescoffier please take a look I will add a test asap for the fixed functionnality, but at least we should see the current test suite still passes. |
|
@cescoffier I had a meeting with @tsegismont who explained me the case, it does avoid some extra boxing and fixes dispatch bugs due to type comparisons not expecting shims but the wrapped types. Let's do a final review once tests have been added. |
tsegismont
force-pushed
the
mutiny-handlers-conversion
branch
2 times, most recently
from
1a25ecd to
d74bbe6
Compare
|
@jponge @cescoffier I've added the test |
tsegismont
force-pushed
the
mutiny-handlers-conversion
branch
from
d74bbe6 to
f7b96d4
Compare
This is port of vert-x3/vertx-rx#324 It fixes Vert.x Web router (and others) that is broken with Mutiny API. See vert-x3/vertx-rx#314 The purpose of this change is to avoid decorating handlers if they are instances of a generated Mutiny type (e.g. io.vertx.mutiny.ext.web.handler.StaticHandler). Signed-off-by: Thomas Segismont <[email protected]>
This test verifies that, when a generated Mutiny handler is set, the bare Vert.x handler is provided to Vert.x, instead of a delegating handler applying redundant conversions (bare->Mutiny->bare). Signed-off-by: Thomas Segismont <[email protected]>
tsegismont
force-pushed
the
mutiny-handlers-conversion
branch
from
f7b96d4 to
9b011d3
Compare
jponge
approved these changes
Jan 9, 2025
|
Hold off merging the PR, I'm trying to determine if we can improve it a little further |
Seems not. Sorry for the noise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is port of vert-x3/vertx-rx#324
It fixes Vert.x Web router (and others) functionnality that is broken with Mutiny API. See vert-x3/vertx-rx#314
The purpose of this change is to avoid decorating handlers if they are instances of a generated Mutiny type (e.g.
io.vertx.mutiny.ext.web.handler.StaticHandler).