Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HostAliases #190

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Add support for HostAliases #190

merged 1 commit into from
Sep 11, 2024

Conversation

lwille
Copy link
Contributor

@lwille lwille commented Aug 21, 2024

Description

Our use case requires adding some aliases to /etc/hosts.
Kubernetes allows specifying hostAliases on a Pod like so:

    spec:
      hostAliases:
        - hostnames:
          - example.net
          ip: 127.0.0.1

We've tested this change in our environment and it works well.
It also passes testing with kubeconform:

helm template step-certificates step-certificates --set-json hostAliases='[{"ip":"127.0.0.1", "hostnames":["example.net"]}]' | kubeconform

Please cut a minor release after merging, so we can use it at @wireapp.

❤ Thank you for accepting this humble contribution!

@lwille lwille requested a review from a team as a code owner August 21, 2024 15:41
@CLAassistant
Copy link

CLAassistant commented Aug 21, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Aug 21, 2024
@lwille
Copy link
Contributor Author

lwille commented Sep 4, 2024

@maraino @hslatman I just resynced our fork, do you have any feedback regarding the change?

@hslatman hslatman merged commit a259a2e into smallstep:master Sep 11, 2024
2 checks passed
@hslatman
Copy link
Member

Thank you, @lwille 😄

@lwille
Copy link
Contributor Author

lwille commented Sep 17, 2024

@hslatman would you mind bumping the chart version and releasing it? I've already published a PR to bump the version: #194

@hslatman
Copy link
Member

Have opened #195 instead.

@lwille
Copy link
Contributor Author

lwille commented Sep 17, 2024

Nice, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants