Don’t need to initialize VMClass fields a second time, already done b…

…y VMObject Signed-off-by: Stefan Marr <[email protected]>
smarr · Aug 16, 2024 · ebe195a · ebe195a
1 parent 200eef7
commit ebe195a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/vmobjects/VMClass.cpp b/src/vmobjects/VMClass.cpp
@@ -45,10 +45,8 @@
 
 const size_t VMClass::VMClassNumberOfFields = 4;
 
-VMClass::VMClass()
-    : VMObject(VMClassNumberOfFields, sizeof(VMClass)), name(nullptr),
-      instanceFields(nullptr), instanceInvokables(nullptr),
-      superClass(nullptr) {}
+// NOLINTNEXTLINE(cppcoreguidelines-pro-type-member-init)
+VMClass::VMClass() : VMObject(VMClassNumberOfFields, sizeof(VMClass)) {}
 
 VMClass* VMClass::CloneForMovingGC() const {
     auto* clone =
@@ -60,6 +58,7 @@ VMClass* VMClass::CloneForMovingGC() const {
     return clone;
 }
 
+// NOLINTNEXTLINE(cppcoreguidelines-pro-type-member-init)
 VMClass::VMClass(size_t numberOfFields, size_t additionalBytes)
     : VMObject(numberOfFields + VMClassNumberOfFields,
                additionalBytes + sizeof(VMClass)) {}

diff --git a/src/vmobjects/VMClass.h b/src/vmobjects/VMClass.h
@@ -81,6 +81,7 @@ class VMClass : public VMObject {
     make_testable(public);
 
     // Remember to update Parser::superclass when the fields are changed
+    // Theses are treated like VMObject fields and initialized that way
     GCSymbol* name;
     GCArray* instanceFields;
     GCArray* instanceInvokables;